Skip to content

book: cover UFCS in Syntax Index #31222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2016
Merged

book: cover UFCS in Syntax Index #31222

merged 2 commits into from
Jan 28, 2016

Conversation

durka
Copy link
Contributor

@durka durka commented Jan 26, 2016

@@ -117,6 +117,9 @@
* `super::path`: path relative to the parent of the current module. See [Crates and Modules (Re-exporting with `pub use`)].
* `type::ident`: associated constants, functions, and types. See [Associated Types].
* `<type>::…`: associated item for a type which cannot be directly named (*e.g.* `<&T>::…`, `<[T]>::…`, *etc.*). See [Associated Types].
* `Trait::method(…)`: disambiguating a method call by naming the trait which defines it. See [Universal Function Call Syntax].
* `Type::method(…)`: disambiguating a method call by naming the type for which it's defined. See [Universal Function Call Syntax].
* `<Type as Trait>::method(…)`: disambiguating a method call by naming the trait _and_ type. See [Universal Function Call Syntax (Angle-bracket Form)].
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I should follow the (IMO odd) all-lowercase convention for these entries.

@durka
Copy link
Contributor Author

durka commented Jan 26, 2016

Updated to follow the capitalization convention and cover the case of associated types (e.g. <Type as Trait>::Assoc).

@steveklabnik
Copy link
Member

So, one thing here is that we've been meaning to rename UFCS for a long time, because it's a really bad name.

/cc @eddyb @rust-Lang/core

On Jan 26, 2016, 14:37 -0500, Alex [email protected], wrote:

Updated to follow the capitalization convention and cover the case of associated types (e.g.::Assoc).


Reply to this email directly orview it on GitHub(#31222 (comment)).

@durka
Copy link
Contributor Author

durka commented Jan 26, 2016

How about something like "Fully Qualified Item" (by analogy with FQDN)?

@eddyb
Copy link
Member

eddyb commented Jan 26, 2016

I agree on using "fully qualified", although there are "partially qualified" forms too.

@steveklabnik I don't think that worked. cc @rust-lang/core

@steveklabnik
Copy link
Member

I think I'm gonna merge this, since it's not fair to block it on renaming UFCS. I just wanted to raise the issue.

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 27, 2016

📌 Commit 2f633b2 has been approved by steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request Jan 27, 2016
@bors
Copy link
Collaborator

bors commented Jan 27, 2016

⌛ Testing commit 2f633b2 with merge 6d9bdac...

@bors
Copy link
Collaborator

bors commented Jan 27, 2016

💔 Test failed - auto-mac-32-opt

@alexcrichton
Copy link
Member

@bors: retry

On Wed, Jan 27, 2016 at 12:26 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-mac-32-opt
http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/7874


Reply to this email directly or view it on GitHub
#31222 (comment).

bors added a commit that referenced this pull request Jan 27, 2016
@bors bors merged commit 2f633b2 into rust-lang:master Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants